Fixes #1813 #1863
Merged
Fixes #1813 #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
catarak
approved these changes
Jun 11, 2021
Member
catarak
left a comment
catarak
left a comment
There was a problem hiding this comment.
Working great for me! Thank you for working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813
As per comment #1813 (comment) I went with option 2. I.e., when you click "New sketch" on the Dashboard, it was previous just a navigation that preserved the current project. Now the button has a handler that calls newProject().
I did not choose option 1, because I think that's less consistent. Namely: when you have a sketch that is saved and go to the Dashobard, the current project is preserved. If you hit "back to sketch" or explicitly navigate to the base URL, the sketch will still be there. By choosing option 1, the same behavior remains with unsaved sketches.
I have verified that this pull request:
npm run lint)developbranch. (If I was asked to make more changes, I have made sure to rebase ontodevelopthen too)Fixes #123